sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Hubs/Scopes Merge 39 - Review Changes

Open adinauer opened this issue 1 year ago • 2 comments

#skip-changelog

:scroll: Description

Changes that came up in reviews of previous PRs and other discussions.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 23 '24 10:04 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against fa046df54d6b8ba8dcd6dbec4297719a71628a94

github-actions[bot] avatar Apr 23 '24 10:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 373.40 ms 460.19 ms 86.79 ms
Size 1.70 MiB 2.28 MiB 595.64 KiB

Previous results on branch: feat/hsm-39-review-changes

Startup times

Revision Plain With Sentry Diff
8f326ed4dca87bf33dbe669e6e5bd7c073e7963d 393.18 ms 478.63 ms 85.45 ms
c1e742eb9eed6ed1450dc6cdcc64657bb3a67604 402.33 ms 518.52 ms 116.19 ms

App size

Revision Plain With Sentry Diff
8f326ed4dca87bf33dbe669e6e5bd7c073e7963d 1.70 MiB 2.28 MiB 595.63 KiB
c1e742eb9eed6ed1450dc6cdcc64657bb3a67604 1.70 MiB 2.28 MiB 595.64 KiB

github-actions[bot] avatar Apr 23 '24 10:04 github-actions[bot]