sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Hubs/Scopes Merge 38 - Use `ScopeType.COMBINED` for cross platform (`InternalSentrySdk`)

Open adinauer opened this issue 1 year ago • 2 comments

#skip-changelog

:scroll: Description

To send values from all scope types (global, isolation, current) to cross platform SDKs we use ScopeType.COMBINED for .configureScope to retrieve all tags, breadcrumbs etc.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 19 '24 11:04 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 130f96688ed358d287d48d02160f54c797bbb836

github-actions[bot] avatar Apr 19 '24 11:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 379.04 ms 431.88 ms 52.83 ms
Size 1.70 MiB 2.28 MiB 595.24 KiB

Previous results on branch: feat/hsm-38-combined-scope-for-cross-platform

Startup times

Revision Plain With Sentry Diff
d429cf3de8e94b612d7e8ed92f420651f9d3e5e9 405.68 ms 497.78 ms 92.09 ms

App size

Revision Plain With Sentry Diff
d429cf3de8e94b612d7e8ed92f420651f9d3e5e9 1.70 MiB 2.28 MiB 595.24 KiB

github-actions[bot] avatar Apr 19 '24 12:04 github-actions[bot]