sentry-java
sentry-java copied to clipboard
Hubs/Scopes Merge 33 - No longer replace global scope
#skip-changelog
:scroll: Description
We're now instantiating globalScope with default SentryOptions. These are replaced in a static {} block for SentryAndroid (temporarily) and then replaced on Sentry.init to actually use options customized by the user.
Also remove options from Scopes and instead use globla scope options (via CombinedScopeView).
:bulb: Motivation and Context
Before we were replacing global scope on Sentry.init.
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Generated by :no_entry_sign: dangerJS against 0b5a5a0ac0689c76a40f72b7a7d811c864a15cb6
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 386.67 ms | 465.00 ms | 78.33 ms |
| Size | 1.70 MiB | 2.28 MiB | 596.26 KiB |
Previous results on branch: feat/hsm-33-no-longer-replace-global-scope
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 098d86bf7182637f82bd0e58cfdf14f0d29a9826 | 366.02 ms | 442.43 ms | 76.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 098d86bf7182637f82bd0e58cfdf14f0d29a9826 | 1.70 MiB | 2.28 MiB | 596.26 KiB |