sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Supply a token for CODECOV and bump to action v4

Open adinauer opened this issue 1 year ago • 1 comments

#skip-changelog

:scroll: Description

Supply a token and use v4 of codecov-action

:bulb: Motivation and Context

Without a token codecov API usage may be rate limited. This should prevent it.

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 11 '24 04:04 adinauer

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 390.22 ms 485.49 ms 95.27 ms
Size 1.70 MiB 2.28 MiB 592.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0404ea31dd7e67983b3aa0133a0dc4fb6b983884 394.73 ms 461.79 ms 67.06 ms
d00722594da449318b4cbcc7ce104d2bbc1c050b 365.63 ms 438.24 ms 72.62 ms
c7e2fbc59ddc599ea7fe0bf4cd1e11a9e34722af 372.00 ms 461.71 ms 89.71 ms
8838e0153bddc7d1fc61c2090eb64c90c199295e 387.41 ms 467.00 ms 79.59 ms
4e290632c3083233d83c696533ee1e0d284dfd42 384.14 ms 447.74 ms 63.60 ms
4e260b39672c0cc6383209cec9f3300ac5596e36 388.40 ms 468.98 ms 80.58 ms
c7e2fbc59ddc599ea7fe0bf4cd1e11a9e34722af 393.98 ms 478.24 ms 84.27 ms
95a98b5e5f5de2caf8887af12ffa59b69d9f14a2 379.14 ms 420.80 ms 41.66 ms
a33b07683d6fe58c9eae5c68dae508d1565b4561 390.44 ms 460.29 ms 69.85 ms
2465853df157c4ad881166804873989c47c10f4d 422.61 ms 491.20 ms 68.58 ms

App size

Revision Plain With Sentry Diff
0404ea31dd7e67983b3aa0133a0dc4fb6b983884 1.72 MiB 2.29 MiB 577.52 KiB
d00722594da449318b4cbcc7ce104d2bbc1c050b 1.70 MiB 2.27 MiB 586.31 KiB
c7e2fbc59ddc599ea7fe0bf4cd1e11a9e34722af 1.72 MiB 2.29 MiB 576.40 KiB
8838e0153bddc7d1fc61c2090eb64c90c199295e 1.72 MiB 2.29 MiB 578.15 KiB
4e290632c3083233d83c696533ee1e0d284dfd42 1.72 MiB 2.29 MiB 578.38 KiB
4e260b39672c0cc6383209cec9f3300ac5596e36 1.72 MiB 2.27 MiB 554.95 KiB
c7e2fbc59ddc599ea7fe0bf4cd1e11a9e34722af 1.72 MiB 2.29 MiB 576.40 KiB
95a98b5e5f5de2caf8887af12ffa59b69d9f14a2 1.70 MiB 2.27 MiB 586.31 KiB
a33b07683d6fe58c9eae5c68dae508d1565b4561 1.70 MiB 2.28 MiB 592.32 KiB
2465853df157c4ad881166804873989c47c10f4d 1.70 MiB 2.27 MiB 583.82 KiB

Previous results on branch: adinauer-patch-1

Startup times

Revision Plain With Sentry Diff
cc070f993fe388513e3966717d2c91afc700d9e5 404.94 ms 468.22 ms 63.28 ms
8f0708b4cb87a9cca1c3fdfc080850d09b41e6e8 372.85 ms 446.00 ms 73.15 ms

App size

Revision Plain With Sentry Diff
cc070f993fe388513e3966717d2c91afc700d9e5 1.70 MiB 2.28 MiB 592.32 KiB
8f0708b4cb87a9cca1c3fdfc080850d09b41e6e8 1.70 MiB 2.28 MiB 592.12 KiB

github-actions[bot] avatar Apr 11 '24 04:04 github-actions[bot]