sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Implementation for server-side baggage support and third party header handling

Open lbloder opened this issue 3 years ago • 4 comments

Implements server side baggage support and handling of third party baggage headers

:scroll: Description

:bulb: Motivation and Context

Fixes #2085

:green_heart: How did you test it?

:pencil: Checklist

  • [x] I reviewed the submitted code
  • [x] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [x] No breaking changes

:crystal_ball: Next steps

lbloder avatar Aug 29 '22 23:08 lbloder

Codecov Report

Base: 80.62% // Head: 80.53% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (e4e169b) compared to base (1e4690d). Patch coverage: 78.14% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2226      +/-   ##
============================================
- Coverage     80.62%   80.53%   -0.10%     
- Complexity     3368     3393      +25     
============================================
  Files           240      240              
  Lines         12388    12461      +73     
  Branches       1646     1659      +13     
============================================
+ Hits           9988    10035      +47     
- Misses         1791     1813      +22     
- Partials        609      613       +4     
Impacted Files Coverage Δ
...n/java/io/sentry/apollo/SentryApolloInterceptor.kt 81.57% <0.00%> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/NoOpSpan.java 25.00% <ø> (ø)
...entry/src/main/java/io/sentry/NoOpTransaction.java 25.71% <ø> (ø)
sentry/src/main/java/io/sentry/TraceContext.java 82.83% <ø> (-0.60%) :arrow_down:
...ring/tracing/SentrySpanClientWebRequestFilter.java 63.63% <33.33%> (-3.87%) :arrow_down:
...ry/src/main/java/io/sentry/TransactionContext.java 60.78% <46.66%> (-14.22%) :arrow_down:
sentry/src/main/java/io/sentry/BaggageHeader.java 81.81% <75.00%> (+19.31%) :arrow_up:
sentry/src/main/java/io/sentry/Baggage.java 83.22% <81.18%> (-6.20%) :arrow_down:
sentry/src/main/java/io/sentry/SentryTracer.java 90.82% <85.00%> (-0.66%) :arrow_down:
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 06 '22 21:09 codecov-commenter

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 334.65 ms 358.82 ms 24.16 ms
Size 1.74 MiB 2.33 MiB 605.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d89dea01bc94d77c82e013014fd7be0541fff62 322.38 ms 350.82 ms 28.45 ms
1e4690d24ef94b303d6b8f1bff3060eb7422e168 354.69 ms 387.88 ms 33.19 ms
3d89dea01bc94d77c82e013014fd7be0541fff62 345.59 ms 364.06 ms 18.47 ms

App size

Revision Plain With Sentry Diff
3d89dea01bc94d77c82e013014fd7be0541fff62 1.74 MiB 2.33 MiB 604.92 KiB
1e4690d24ef94b303d6b8f1bff3060eb7422e168 1.74 MiB 2.33 MiB 604.92 KiB
3d89dea01bc94d77c82e013014fd7be0541fff62 1.74 MiB 2.33 MiB 604.92 KiB

Previous results on branch: feat/server_side_baggage

Startup times

Revision Plain With Sentry Diff
d0f05d5ddbf353495d9b76995b96e52f05478d85 355.79 ms 394.62 ms 38.83 ms

App size

Revision Plain With Sentry Diff
d0f05d5ddbf353495d9b76995b96e52f05478d85 1.74 MiB 2.33 MiB 605.50 KiB

github-actions[bot] avatar Sep 19 '22 13:09 github-actions[bot]

LGTM!

@marandaneto do you want to give this a glance since you've seen multiple DS implementations and may notice if something's different here.

adinauer avatar Sep 19 '22 13:09 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against e4e169b2d1493fb3929873718533db7f06eca032

github-actions[bot] avatar Sep 22 '22 14:09 github-actions[bot]

Looks like this can be merged now. @marandaneto should I go ahead an merge?

adinauer avatar Sep 23 '22 06:09 adinauer