Replace ThreadLocal in Sentry with HubStorage and a wrapped ThreadLoc…
…al Hub; also fix Webflux integration and add transaction support for webflux
:scroll: Description
Hackweek project 2022
:bulb: Motivation and Context
- Leak less resources on App server redeploy via ThreadLocal (leaked Hub before, now just a few smaller data structures) #2079
- Fix random breadcrumbs during high server load for Webflux #1790
- Add transaction support for Webflux #1807
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code
- [ ] I added tests to verify the changes
- [ ] I updated the docs if needed
- [ ] No breaking changes
:crystal_ball: Next steps
- More testing
- Fix tests
- Cleanup code
| Fails | |
|---|---|
| :no_entry_sign: | Please consider adding a changelog entry for the next release. |
Instructions and example for changelog
Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:
## Unreleased
- Replace ThreadLocal in Sentry with HubStorage and a wrapped ThreadLoc… ([#2224](https://github.com/getsentry/sentry-java/pull/2224))
If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.
Generated by :no_entry_sign: dangerJS against 8ad9b37e452d0826ebe6ab9d01ca51702a9d956e
Sorry for commenting on this issue specifically, but there is no clear place where this comment should go.
I wonder what the current state of error reporting and automatic transaction capturing with Spring WebFlux is - especially with the Sentry client 6.5.0. I see a couple of PRs that seem related to these issues. I wonder if there is a plan to move forward and maybe areas where help is needed.
Closing this in favor of https://github.com/getsentry/sentry-java/issues/2546