sentry-go icon indicating copy to clipboard operation
sentry-go copied to clipboard
verified publisher icon getsentry

Remove unnecessary dependency update while updating sentry SDK version

Open epikjjh opened this issue 3 years ago • 1 comments

Summary

Current sentry-go has a dependency with gin, so when we are going to update the sentry-go version, it requires an update of the proper gin version too.

However, by searching this repository, gin is only used for creating test & example codes.

Motivation

When I update sentry SDK version from v0.11.0 to v0.13.0, I found out it requires an update for gin too. However, updating gin version seems unnecessary to us since this is actually not used in sentry. It seems to be a burden for users to consider unnecessary dependency updates.

Could you please consider this case? 🙏

Additional Context

epikjjh avatar May 10 '22 20:05 epikjjh

This is true for all the "web-framework" (or logger) dependencies. They should be removed from the main sentry-go library in my opinion. sentry-go is a library package and should have minimum dependencies. I use none of the sentry-go imported web frameworks so I don't want to have a dependency on them, but I'm forced to. 😞

Some related issues which underline that it might was a bad decision by sentry to import all kinds of things into the main sentry-go package:

  • https://github.com/getsentry/sentry-go/issues/442
  • https://github.com/getsentry/sentry-go/issues/441
  • https://github.com/getsentry/sentry-go/issues/438
  • https://github.com/getsentry/sentry-go/issues/423
  • https://github.com/getsentry/sentry-go/issues/340

It would be way better to provide separate packages containing the integrations for web-frameworks or loggers. This gives (paying) users of Sentry the freedom to choose what they are depending on in their codebase!

ghouscht avatar Jun 16 '22 06:06 ghouscht

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Dec 07 '22 09:12 github-actions[bot]

Unfortunately this is still a problem but this issue didn't get attention so far...

ghouscht avatar Dec 07 '22 12:12 ghouscht

Let's track this in https://github.com/getsentry/sentry-go/issues/156 We are very well aware of this, so it will be improved in the future!

cleptric avatar Dec 07 '22 14:12 cleptric

@cleptric #156 exists for 3 years now and nothing is being done about it. :(

dolmen avatar Apr 13 '23 13:04 dolmen