sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Document new configuration option

Open soerface opened this issue 1 year ago • 2 comments

Pre-merge checklist

  • [x] Checked Vercel preview for correctness, including links
  • [ ] PR was reviewed and approved by any necessary SMEs
  • [ ] PR was reviewed and approved by a member of the Sentry docs team

Description of changes

This is documenting a new configuration option I proposed here: getsentry/sentry-javascript#11153 The PR in the js SDK repository is currently reviewed by @billyvg. Therefore, I'm leaving this note here so we don't forget to update the docs as soon as the feature is merged and released with the next SDK version.

HINT: The documentation is also featuring this image: https://docs.sentry.io/platforms/javascript/common/user-feedback/configuration/user-feedback-widget-customization.png Maybe we should get a sentry graphics designer involved to update the image, indicating that now also the "(required)" text is configurable.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

soerface avatar Mar 20 '24 23:03 soerface

@soerface is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 20 '24 23:03 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 8:53pm

vercel[bot] avatar Mar 20 '24 23:03 vercel[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Apr 12 '24 07:04 getsantry[bot]

The feature has been released in 7.109.0: https://github.com/getsentry/sentry-javascript/releases/tag/7.109.0

Therefore, I think that the documentation change is ready to be merged.

soerface avatar Apr 12 '24 07:04 soerface