sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

[DRAFT] UI redesign

Open a-hariti opened this issue 1 year ago • 8 comments

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • [ ] Checked Vercel preview for correctness, including links
  • [ ] PR was reviewed and approved by any necessary SMEs
  • [ ] PR was reviewed and approved by a member of the Sentry docs team

Description of changes

a wip branch to implement the new design

related #9369

a-hariti avatar Mar 12 '24 23:03 a-hariti

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:27pm

vercel[bot] avatar Mar 12 '24 23:03 vercel[bot]

@a-hariti this is a good first step!

Here are some changes we'd need to make in order of priority:

  • we would like to see an option of the platform dropdown that has both the languages and the frameworks as in this image: Screenshot 2024-03-13 at 12 40 25 PM

  • we want to get rid of the separate product nav and move it so that it lives persistently even when users choose their SDK. (As a next step we'll need to reorganize the folder structure of the product docs, but we can do that a bit later.) Screenshot 2024-03-13 at 12 55 58 PM

  • Python frameworks currently live in the "integration" section of docs, we'd need to make sure they are also visible in the dropdown. Screenshot 2024-03-13 at 12 58 51 PM

  • Would like to see an option where there are 2 dropdown selectors, one for language and another for framework: Screenshot 2024-03-13 at 1 04 29 PM

  • We don't need to worry about this right now, but of course we'd also need to update the colors/font styles etc. to reflect the new design:

Screenshot 2024-03-13 at 1 17 39 PM

lizokm avatar Mar 13 '24 20:03 lizokm

Can the nested dropdown and two drop downs (for platforms & guides) coexist @lizokm ?

a-hariti avatar Mar 14 '24 12:03 a-hariti

@a-hariti I don't think it makes sense for the nested dropdown and the two drop downs (for platforms & guides) to coexist. It should be one or the other.

Also, I resolved a conflict that may have led to more conflicts in the sidenav. Are you able to see the previews?

lizokm avatar Mar 14 '24 22:03 lizokm

Yes, I can see the previews.

Thank you. I think you accidentally left a foreign string during the conflict resolution 🙊, I'll take care of it

a-hariti avatar Mar 14 '24 22:03 a-hariti

Bundle Report

Changes will increase total bundle size by 629.32kB :arrow_up:

Bundle name Size Change
sentry-docs-server 7.42MB 259.74kB :arrow_up:
sentry-docs-edge-server 456.19kB 13.27kB :arrow_up:
sentry-docs-client 6.2MB 356.32kB :arrow_up:

codecov[bot] avatar Mar 15 '24 15:03 codecov[bot]

@lizokm should the python integrations be converted to guides in the docs or should we just change to the way they are represented in the UI?

The second option will add some hardcoded logic for python in the code base

a-hariti avatar Mar 20 '24 15:03 a-hariti

@stephanie-anderson @antonpirker would love your thoughts here: should the python integrations be converted to guides in the docs or should we just change to the way they are represented in the UI?

The second option will add some hardcoded logic for python in the code base

lizokm avatar Mar 21 '24 22:03 lizokm

Deployment failed with the following error:

Could not parse File as JSON: vercel.json

vercel[bot] avatar Apr 13 '24 00:04 vercel[bot]

You must have Developer access to commit code to Sentry on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/concepts/teams/roles-and-permissions#enterprise-team-account-roles

vercel[bot] avatar Apr 17 '24 12:04 vercel[bot]

Deployment failed with the following error:

Redirect at index 1 has segment ":__UN_NAMED_SEGMENT__" in `destination` property but not in `source` or `has` property.

Learn More: https://vercel.link/invalid-route-destination-segment

vercel[bot] avatar Apr 29 '24 12:04 vercel[bot]