sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Clarify Ownership Rules > Evaluation Flow

Open ericemmrich opened this issue 1 year ago • 6 comments

DESCRIBE YOUR PR

Based on the docs and my own observations, I feel like the evaluation flow is documented incorrectly.

The docs state "If there are multiple owners in the rule, left-to-right. After evaluation, the last rule matching returns the assignment.". But then stated in the example: "Evaluate the rule left-to-right; we choose the first owner." Shouldn't this be "we choose the last owner" then?

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • [ ] Urgent deadline (GA date, etc.):
  • [ ] Other deadline:
  • [x] None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • [ ] Checked Vercel preview for correctness, including links
  • [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • [ ] PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

ericemmrich avatar Aug 28 '24 10:08 ericemmrich

@ericemmrich is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 28 '24 10:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:24pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 10:24pm

vercel[bot] avatar Aug 28 '24 22:08 vercel[bot]

@jangjodi can you verify?

vivianyentran avatar Aug 28 '24 22:08 vivianyentran

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Sep 20 '24 07:09 getsantry[bot]

Is there any update on this?

ericemmrich avatar Sep 23 '24 16:09 ericemmrich

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Oct 15 '24 07:10 getsantry[bot]