sentry-cli icon indicating copy to clipboard operation
sentry-cli copied to clipboard

`sentry-cli` should not pollute envs for `react-native-xcode.sh`

Open krystofwoldrich opened this issue 2 years ago • 1 comments

When sentry-cli load envs from .env the react native Xcode script it wraps inherits all the loaded envs which clashes with other react native libraries loading envs during the bundling process.

  • This was brought up in https://github.com/getsentry/sentry-react-native/issues/3625#issuecomment-1960298374
  • More in-depth explanation by the react-native-dotenv maintainers here https://github.com/goatandsheep/react-native-dotenv/issues/393#issuecomment-1468630722

Solution

sentry-cli should not pass the envs loaded from .env files to the script it wraps.

krystofwoldrich avatar Feb 23 '24 11:02 krystofwoldrich

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Mar 19 '24 00:03 github-actions[bot]