sentry-cli icon indicating copy to clipboard operation
sentry-cli copied to clipboard

Upgrade to node-fetch v3 to avoid punycode deprecation warning

Open andrews05 opened this issue 2 years ago • 11 comments

On node 21, using sentry cli shows a warning: DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Here's the dependency stack leading to punycode:

@sentry/cli@npm:2.21.2
node-fetch@npm:2.7.0
whatwg-url@npm:5.0.0
tr46@npm:0.0.3
punycode

Upgrading to node-fetch v3 should resolve this. I believe this will require bumping minimum node to v12, hopefully that won't be issue.

andrews05 avatar Nov 08 '23 22:11 andrews05

Hi, thank you for the report. I'll put it on the backlog for now.

loewenheim avatar Nov 09 '23 10:11 loewenheim

Any news about this? Node 21 was released 5 months ago :(

emmgfx avatar Mar 22 '24 09:03 emmgfx

@emmgfx Since implementing this change would require increasing the minimum Node version, this change likely should wait until we release a new major version of the CLI.

If this deprecation warning is a major annoyance, we could perhaps look into whether we might be able to suppress the warning in the meantime.

szokeasaurusrex avatar Mar 22 '24 09:03 szokeasaurusrex