No error message when Visual C++ Redistributable is not installed (again)

[ADTC]

Environment

What version of the CLI and what OS are you running?

• Windows 11 22H2
• Sentry CLI 1.75.2

Steps to Reproduce

What you did?

• Get a new Windows computer.
• Run npm install on a project with @sentry/nextjs or @sentry/javascript package.

Actual Result

The errors were confusing. I thought it has something to do with punycode but apparently not! This was because Microsoft Visual C++ redistributable was not installed.

C:\Users\ADTC\Git\myproject>npm i
npm ERR! code 1
npm ERR! path C:\Users\ADTC\Git\myproject\node_modules\@sentry\cli
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c node ./scripts/install.js
npm ERR! [sentry-cli] Using cached binary: C:\Users\ADTC\AppData\Local\npm-cache\sentry-cli\d8411c-sentry-cli-Windows-x86-64.exe
npm ERR! (node:10488) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
npm ERR! (Use `node --trace-deprecation ...` to show where the warning was created)
npm ERR! Error: Command failed: C:\Users\ADTC\Git\myproject\node_modules\@sentry\cli\sentry-cli.exe --version

npm ERR! A complete log of this run can be found in: C:\Users\ADTC\AppData\Local\npm-cache\_logs\2023-11-07T11_50_42_505Z-debug-0.log

C:\Users\ADTC\Git\myproject>cd C:\Users\ADTC\Git\myproject\node_modules\@sentry\cli

C:\Users\ADTC\Git\myproject\node_modules\@sentry\cli>C:\WINDOWS\system32\cmd.exe /d /s /c node --trace-deprecation ./scripts/install.js
[sentry-cli] Downloading from https://downloads.sentry-cdn.com/sentry-cli/1.75.2/sentry-cli-Windows-x86_64.exe
(node:2064) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)
    at loadBuiltinModule (node:internal/modules/helpers:101:7)
    at Module._load (node:internal/modules/cjs/loader:1001:17)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (C:\Users\ADTC\Git\myproject\node_modules\whatwg-url\lib\url-state-machine.js:2:18)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
fetching sentry-cli-Windows-x86_64.exe ████████████████████ 100% 0.0s
[sentry-cli] Checksum validation passed.
Error: Command failed: C:\Users\ADTC\Git\myproject\node_modules\@sentry\cli\sentry-cli.exe --version

Expected Result

If the redistributable is not installed, sentry-cli.exe --version should warn, not just about the missing DLL, but also how to fix the problem (i.e., tell me to install the redistributable).

Moreover, it should not only display a pop-up message window but also output this message to the command line. The issue with the pop-up window is that it never shows when the command is run as part of the install script.

Related: #118 #267 #922 #1319

[loewenheim]

Hi, thank you for the report. I'll have a look as soon as possible.

[github-actions[bot]]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[ADTC]

Say NO to StaleBot!