sentry-cli icon indicating copy to clipboard operation
sentry-cli copied to clipboard

upload-dif --no-upload should display what files would be uploaded

Open benpeck-eepics opened this issue 3 years ago • 2 comments

Using sentry-cli 2.3.1 release on Windows 10

When using the --no-upload flag to upload-dif, the cli immediately returns and says skipping upload.

It would be much more useful if the cli went ahead and listed which files it detected in the path I supplied, analyzed them, and listed which are considered new files before deciding not to upload any of them.

Thanks!

benpeck-eepics avatar Jul 13 '22 00:07 benpeck-eepics

Thanks for the feedback. It sounds reasonable, however, it's more work than just printing this data right now.

The things that will end up being uploaded, are dependent on the receiving server's capabilities. Each server can change its handled formats and disable/enable specific features. Thus for us to know what will effectively be uploaded, we need to do some processing and "server talk" beforehand.

I will leave this issue open so we can have a reference to it once there is some spare time for such improvements. Thanks!

kamilogorek avatar Jul 14 '22 09:07 kamilogorek

Ok thanks for the response. As added motivation, the current documentation really makes it sound like this flag behaves in the why I describe in the original post (bold is my emphasis):

--no-upload Disables the actual upload. This runs all steps for the processing but does not trigger the upload (this also automatically disables reprocessing). This is useful if you just want to verify the setup or skip the upload in tests.

benpeck-eepics avatar Aug 16 '22 22:08 benpeck-eepics