self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

Missing Discover Icon

Open JonPurvis opened this issue 1 year ago • 2 comments

Self-Hosted Version

24.8.0

CPU Architecture

x86_64

Docker Version

24.0.7

Docker Compose Version

2.29.2

Steps to Reproduce

  1. Go to Dashboard
  2. Look at Discover Link in menu
  3. You should see a dot instead of an icon

I'm running on an Errors Only Sentry instance, not sure if that has any bearing.

Expected Result

In previous versions of Sentry, this is a telescope.

Actual Result

Image

Event ID

No response

JonPurvis avatar Sep 12 '24 10:09 JonPurvis

Thanks for reporting this! I believe this regression was introduced when we reworked the sidebar for Sentry

hubertdeng123 avatar Sep 13 '24 22:09 hubertdeng123

Just dug around. This is not a bug, see this line:

https://github.com/getsentry/sentry/blob/fa5c96d58debe2db4f3b1c8896f6944988d73904/static/app/components/sidebar/index.tsx#L243

Compared to the previous change that has <IconTelescope> component on it:

https://github.com/getsentry/sentry/blob/ccb3c648d0d065bfe84840d1956fb0a9f5ab3544/static/app/components/sidebar/index.tsx#L236

It's intended, but it'd surely be nicer if it's a telescope icon though.

aldy505 avatar Sep 17 '24 02:09 aldy505

cc @gggritso who made that sidebar update

ryan953 avatar Dec 11 '24 00:12 ryan953

@gggritso please could you fix the icon, it's bugging me more than it should be 😆 😢

JonPurvis avatar Dec 11 '24 01:12 JonPurvis

@JonPurvis wow that is annoying! Yes, I'll fix this.

I'm running on an Errors Only Sentry instance, not sure if that has any bearing.

This is very helpful 👍🏻

gggritso avatar Dec 11 '24 19:12 gggritso

@JonPurvis fix will be in the next release of self-hosted! Thanks for raising this 👍🏻

gggritso avatar Dec 11 '24 21:12 gggritso