Fix logic in find_dylib() and find_header()

Open nbigaouette opened this issue 7 years ago • 2 comments

Milksnake does not support searching for dylib/header in absolute directory.

It appends path to the in_path variable (if given): https://github.com/getsentry/milksnake/blob/ef0723e/milksnake/setuptools_ext.py#L146

This prevent setting CARGO_TARGET_DIR to an absolute path different of the rust/ subdirectory.

This PR changes the logic so that appending happens only if in_path is not an absolute path. Also, this in_path is normalized as described in #24.

Closes #24.

Jan 20 '19 20:01 nbigaouette

Apologies if bumping this is poor form, but I ran into this same issue today. Could this be merged and published in a new version?

Thanks!

Jun 16 '20 15:06 jgallagher-cs

Is something blocking this PR from getting merged?

Jun 13 '21 17:06 johntrimble