setup icon indicating copy to clipboard operation
setup copied to clipboard

Docker compose YAML link broken in setup docs

Open rdbell opened this issue 1 year ago • 1 comments

https://redash.io/help/open-source/setup#docker

<li>Download our recommended <a href="[https://github.com/getredash/setup/blob/master/data/docker-compose.yml](view-source:https://github.com/getredash/setup/blob/master/data/docker-compose.yml)" target="_blank" rel="nofollow noopener noreferrer">Docker Compose configuration</a> and create initial configuration.</li>
<p>To run Redash you need several instances of Redash (API server and background workers to run queries) along with Redis and PostgreSQL. If you don’t want or can’t use our images or <a href="[https://github.com/getredash/setup](view-source:https://github.com/getredash/setup)" target="_blank" rel="nofollow noopener noreferrer">Setup Script</a>, you can refer to the <a href="[https://github.com/getredash/setup/blob/master/data/docker-compose.yml](view-source:https://github.com/getredash/setup/blob/master/data/docker-compose.yml)" target="_blank" rel="nofollow noopener noreferrer">Docker Compose configuration</a> to understand what services you need to define.</p>

rdbell avatar Apr 29 '24 13:04 rdbell

Oh, good point. I've been updating the build pieces of this setup script, but haven't really taken a step back and looked at things like that.

I'll take a look at it some time over the next few days.

Thanks for bringing it to our attention @rdbell. :smile:

justinclift avatar Apr 29 '24 16:04 justinclift

Ok, it's taking more than a few days. It'll probably be this weekend sometime though, as I'm already doing some housekeeping for projects. :smile:

justinclift avatar May 11 '24 07:05 justinclift

@justinclift Looking at the history, it was a minor issue with a file name chnage(docker-compose.yml to compose.yaml) If you don't mind, can I fix it and create a PR?

lucydodo avatar May 11 '24 08:05 lucydodo

Definitely, go for it. :smile:

justinclift avatar May 11 '24 08:05 justinclift

PR: https://github.com/getredash/website/pull/701 Cool, I've make a PR to patch with what @rdbell mentioned, as well as a couple other pieces of text that weren't edited.

lucydodo avatar May 11 '24 08:05 lucydodo

@rdbell The documentation has been updated to use the new compose.yaml name now, thanks to the PR from @lucydodo. :smile:

justinclift avatar May 11 '24 08:05 justinclift