contrib-helm-chart icon indicating copy to clipboard operation
contrib-helm-chart copied to clipboard

Update chart dependencies

Open ArcticXWolf opened this issue 2 years ago • 17 comments

I have updated the postgresql and redis dependencies of this chart.

This introduced a breaking change for the postgresql credentials/secret:

  1. Helm values.yaml changes from postgresql.postgresqlUsername -> postgresql.auth.username
  2. Helm values.yaml changes from postgresql.postgresqlPassword -> postgresql.auth.password
  3. Helm values.yaml changes from postgresql.postgresqlDatabase -> postgresql.auth.database
  4. The key of the postgresql password secret changed from postgresql-password to password

So we need to do two things before merge and I would like to have your opinion on this:

  1. How do we deal and communicate the breaking changes?
  2. Update chart version number

ArcticXWolf avatar May 24 '23 10:05 ArcticXWolf

@grugnog I failed to launch Redash with this helm and added my comment to https://github.com/getredash/contrib-helm-chart/issues/145. Could you check this PR ?

masayuki038 avatar Oct 15 '23 02:10 masayuki038

@grugnog ping

masayuki038 avatar Oct 23 '23 14:10 masayuki038

[Copied from issue #145] @masayuki038 I dont see any further activity on this repo, so you probably have to fork and use my PR code to get it to work. Just as a headsup: if you want to use my PR, then you need to change your values.yaml keys a bit. I've detailed the changes in the PR description :) Hope it helps a bit!

ArcticXWolf avatar Nov 03 '23 14:11 ArcticXWolf

@justinclift Can you check this if you have some time?

masayuki038 avatar Nov 03 '23 14:11 masayuki038

@masayuki038 I don't really have any clue with Helm, so can't directly help here.

That being said, it looks like @ArcticXWolf might be interested in helping out with this repo?

As in, potentially adding as a member to enable fixing/updating/etc stuff. @ArcticXWolf is that your kind of thing? :smile:

justinclift avatar Nov 04 '23 02:11 justinclift

Sorry, we only tested Redash for a short time and do not use it anymore. I just happened to fix this issue during experimentation. So sadly I wont have time to tend to this repo.

ArcticXWolf avatar Nov 04 '23 15:11 ArcticXWolf

@ArcticXWolf No worries. :smile:

justinclift avatar Nov 04 '23 16:11 justinclift

is it possible to become a maintainer of this repo?

AndrewChubatiuk avatar Dec 24 '23 12:12 AndrewChubatiuk

@AndrewChubatiuk it can be done, but the person will need to have a clear history of competency in the pieces involved. :smile:

justinclift avatar Dec 26 '23 09:12 justinclift

I would like to help with redash helm chart, but have no idea how do you measure competency

AndrewChubatiuk avatar Dec 26 '23 10:12 AndrewChubatiuk

Well, your GitHub profile seems to be completely private. So it's super hard to tell what you're into, what you're good at, look at how well you interact with others, and that kind of thing. :frowning:

justinclift avatar Dec 26 '23 15:12 justinclift

@justinclift my profile should be public now

AndrewChubatiuk avatar Jan 11 '24 09:01 AndrewChubatiuk

@AndrewChubatiuk Cool. Looking over some of your activity for the last several years, it looks legit rather than dodgy. So, no worries from me now. :smile:

justinclift avatar Jan 11 '24 11:01 justinclift

@grugnog Are you ok with @AndrewChubatiuk being added as a maintainer for this repo? :smile:

justinclift avatar Jan 11 '24 11:01 justinclift

@AndrewChubatiuk If we don't get a response in a few days, we can just go ahead and add you as a maintainer. :wink:

justinclift avatar Jan 11 '24 11:01 justinclift

@AndrewChubatiuk Heh Heh Heh, I nearly forgot about this.

As we've not heard anything from @grugnog, I've just sent you an invite for this repo so you can do stuff in it. :smile:

justinclift avatar Jan 25 '24 13:01 justinclift

@justinclift could you please provide me more access in a repo? I want to replace circleci with github actions

AndrewChubatiuk avatar Feb 07 '24 19:02 AndrewChubatiuk

closing this PR as it's covered in #158

AndrewChubatiuk avatar Mar 26 '24 05:03 AndrewChubatiuk

could you please provide me more access in a repo?

@AndrewChubatiuk Oops, I missed that message. Is this something you still need me to look into?

justinclift avatar Mar 26 '24 07:03 justinclift