porter icon indicating copy to clipboard operation
porter copied to clipboard

Add ability to start a span without writing to logger

Open VinozzZ opened this issue 3 years ago • 0 comments

Currently, porter has a TraceLogger wrapper that contains both tracing and logging ability. When a span is created, any information addes to the span through the TraceLogger will also writes to the logger. This creates issue like #2278 which causes the same error being written multiple times in the console. To avoid big changes throughout the entire codebase from a complete redesign and having too much boilerplate, we would like to solve this problem by introducing additional methods onto TracerLogger so that we can create spans without also writing to our logger. One way to achieve this is to change logger sink when creating a span so that writing to logger becomes a no-op operation. We could use some exploration time to try out some options and come up with a long-term solution

VinozzZ avatar Aug 04 '22 16:08 VinozzZ