collect icon indicating copy to clipboard operation
collect copied to clipboard

Run lint/unit tests in CI on release builds

Open yanokwa opened this issue 8 years ago • 4 comments

Currently, we run lint and unit tests against debug builds. This is because developers are generally generating debug builds. On the CI server, we currently test against debug, but it might be a better idea to test against release.

yanokwa avatar Mar 16 '17 18:03 yanokwa

@grzesiek2010, @seadowg this seems worth doing? I think the advantage is that the build would go through all the same transformation as for release. I believe this issue was filed after we had some build issues that only showed up for release.

lognaturel avatar Mar 12 '20 17:03 lognaturel

I don't see any harm in doing it! I haven't seen us run into any of these kinds of issues personally but if there's no blocker to doing it I say we go for it.

seadowg avatar Mar 12 '20 17:03 seadowg

It might be time to take this on. It's no fun to catch issues when doing a release.

yanokwa avatar Sep 23 '21 19:09 yanokwa

I've put up a PR that adds a release build to CI. That's enough to catch the errors we've run into on the last few releases.

seadowg avatar Sep 27 '21 16:09 seadowg

It feels like the above change (and moving QA to a minified build) has helped us a lot with any cracks we were seeing that this might have fixed. Closing this.

seadowg avatar Oct 05 '22 15:10 seadowg