SocketIOClient-Unreal icon indicating copy to clipboard operation
SocketIOClient-Unreal copied to clipboard

Support for server send with ack

Open getnamo opened this issue 7 years ago • 3 comments

From forums (https://forums.unrealengine.com/development-discussion/engine-source-github/82790-plugin-socket-io-client?p=1465276#post1465276), feature request to support ack function in socket.io spec https://socket.io/docs/server-api/#socketemiteventname-args-ack

getnamo avatar Apr 28 '18 13:04 getnamo

Shelved work on https://github.com/getnamo/socketio-client-ue4/tree/issue-79.

The underlying library supports this, but requires an immediate callback on the network thread which is not ideal. Will require architecture thought.

getnamo avatar Jul 28 '19 23:07 getnamo

Hey @getnamo ! Did you ever get anywhere in terms of architecture ideas here? Just started using this lib (and socketio in general) and realized I needed this feature. I've hacked together a change in my fork to enable/disable the auto-ack when connecting, and have the message id passed up in event callbacks, as well as a manual ack function. But it's all feeling pretty messy in the end, so it would be great to have this feature in the main codebase in a more well-structured way.

Repo here if anyone needs a quick and dirty fix in the meantime: https://github.com/HeffU/socketio-client-ue4

HeffU avatar Jan 13 '20 22:01 HeffU

Had a quick look through the commits, it's a pretty thorough implementation, nicely done. How does the siolib ack look like on the server side? If it's functionally the same, with just a bit of cleanup (downstream api mostly) this change could be merged

getnamo avatar Jan 20 '20 00:01 getnamo