maxun icon indicating copy to clipboard operation
maxun copied to clipboard

CORS setup can't seem to work in hosted environment

Open publicvirtualvoid opened this issue 1 year ago • 3 comments

I could be missing something, but I don't think this will ever work in a hosted environment. Does this need to pull the FE path from ENV?

https://github.com/getmaxun/maxun/blob/c9dc44884b46593d93e3dd1ed6dd81c078c774e1/server/src/server.ts#L22-L27

publicvirtualvoid avatar Nov 10 '24 04:11 publicvirtualvoid

@publicvirtualvoid what's your configuration to self host? We currently have provided local development infrastructure and in the next release will help users to self host.

Are you running it on a remote server and have set up a reverse proxy?

We have a few users that have modified our existing codebase to self host and are running it.

amhsirak avatar Nov 10 '24 08:11 amhsirak

I run everything behind traefik and use docker compose labels to configure each service. I think the code just needs to be changed to pull from an env var instead.

publicvirtualvoid avatar Nov 11 '24 04:11 publicvirtualvoid

@publicvirtualvoid I'm working on setting up self-hosted infrastructure. Should be available by this weekend.

amhsirak avatar Nov 13 '24 17:11 amhsirak

fixed in #223

amhsirak avatar Dec 04 '24 17:12 amhsirak