pylon icon indicating copy to clipboard operation
pylon copied to clipboard

fix(detect-pm): default to 'npm run' for unknown package managers

Open schettn opened this issue 11 months ago • 6 comments

schettn avatar Feb 17 '25 15:02 schettn

🦋 Changeset detected

Latest commit: a741aed487af884255718e875cdf358c6f9f5394

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-pylon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 17 '25 15:02 changeset-bot[bot]

🚀 Snapshot Release (canary)

The latest changes of this PR are available as canary on npm (based on the declared changesets):

Package Version Info
create-pylon 1.1.4-canary-20250217154612.a741aed487af884255718e875cdf358c6f9f5394 npm ↗︎ unpkg ↗︎

github-actions[bot] avatar Feb 17 '25 15:02 github-actions[bot]

oh no, It is recommended to allow users to choose their own package manager when did not detected the package manager.

Akimotorakiyu avatar Feb 17 '25 18:02 Akimotorakiyu

This change only defaults to npm run dev for the success message:

image

The auto detection is only used for auto installing the dependencies (if selected) and displaying the correct start scripts.

schettn avatar Feb 17 '25 20:02 schettn

Hi @Akimotorakiyu, could you please test this on your machine?

npm create pylon@1.1.4-canary-20250219195325.e978949d02ea426b3a5c9890a83d38d4d1b34075

schettn avatar Feb 20 '25 15:02 schettn

@schettn sorry, I'm late. image

Akimotorakiyu avatar Feb 25 '25 14:02 Akimotorakiyu