block-lab icon indicating copy to clipboard operation
block-lab copied to clipboard

Editor Fields and Setting Fields should be separate.

Open kopepasah opened this issue 7 years ago • 2 comments

One thing I noticed in the block settings is the combination of the editor and settings (inspector) fields. Because these represent two different ways to manage data, these should be separated out into each's own separate table.

To further distinguish the difference between a "field" and a "setting" we could use the Setting word on the second table.

screen shot 2018-12-05 at 4 33 38 pm

In addition to separating these two types, it would allow us to create setting areas on editor settings panel.

kopepasah avatar Dec 05 '18 07:12 kopepasah

I really like the idea. This makes designing the forms more clear also more easy to sort the fields correctly.

I'm not sure about the wording and distinguishing between Field and Settings in the table header. All Fields are "Fields" and don't really differ because of their current location. I think, the table header labels should be the same for both tables.

Maybe it's better to add a small Header above each table? Below the table header, there could be a short description text for the table to help new users.

  • Block Editor Fields Add form fields which are used in the main block editor of Gutenberg. (+ Add Editor Field)
  • Block Setting Fields Add form fields which are accessable from the block settings panel of Gutenberg. (+ Add Setting Field)
  • [ Block Logic Rules ] Add conditional statements in order to show or hide fields/groups based on a user's previous selection. (+ Add Logic Rule)

Forget about Block Logic Rules. ;) This should be just a placeholder for any other possible table.

camya avatar Dec 05 '18 11:12 camya

We did look at this when we originally looked at letting users add fields as settings (to the inspector). Being that there is not functional difference to what fields can be added between the 2 areas, we felt separating them in to 2 seperate sections was unnecessary, with the current select option being sufficient.

My general opinion is the simplicity offers the most flexibility. I.e. you may put a field in the editor and then later switch it to the inspector. The current implementation makes this nice and simple.

@kopepasah You said "In addition to separating these two types, it would allow us to create setting areas on editor settings panel." Could you expand on this? Not sure I 100% understand.

On all of the above though, I'm happy to be convinced otherwise. :)

RobStino avatar Dec 05 '18 11:12 RobStino