MapStore2 icon indicating copy to clipboard operation
MapStore2 copied to clipboard

Burger menu not visible in DEV for context

Open tdipisa opened this issue 3 years ago • 2 comments

Description

Its seems that due to recent updates in DEV the burger menu is no longer visible in DEV if configured for a context

How to reproduce

  • Open this context in edit mode
  • In the plugin wizard add the burger menu
  • Save and then open the context again

Expected Result

The sidebar disappear and the burger menu is available and functional

Current Result

A sidebar covering the burger menu with only the measurement tool is present.

image.png

  • [x] Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

The tool works well in QA.

Related comment is https://github.com/geosolutions-it/MapStore2/pull/8530#issuecomment-1235240725

tdipisa avatar Aug 30 '22 12:08 tdipisa

Not caused by module plugins, see description here https://github.com/geosolutions-it/MapStore2/issues/8463#issuecomment-1232954389 Requires a minor fix in sidebar menu visibility logic.

alexander-fedorenko avatar Aug 31 '22 13:08 alexander-fedorenko

Relevant comment from @allyoucanmap in #8530 to resume the work for this issue as part of the 2022.02.01 iteration.

tdipisa avatar Sep 02 '22 09:09 tdipisa

@allyoucanmap need to set the alwaysRender flag in the plugin to make it work and make this issue testable?

offtherailz avatar Nov 04 '22 11:11 offtherailz

@offtherailz this PR has already the Measure plugin updated with alwaysRender https://github.com/geosolutions-it/MapStore2/pull/8754/files#diff-434d509b048e12e9e1c4c92944d208355b10faf3f2528ff363b5113199ffb6d7R203

allyoucanmap avatar Nov 04 '22 16:11 allyoucanmap

Sorry my fault. I filtered commits for the review and then I forgot to reset before doing my comment.

offtherailz avatar Nov 04 '22 17:11 offtherailz