MapStore2 icon indicating copy to clipboard operation
MapStore2 copied to clipboard

Versioning of data dirs

Open MV88 opened this issue 3 years ago • 6 comments

Description

Add versioning of data dirs

What kind of improvement you want to add? (check one with "x", remove the others)

  • [ ] Minor changes to existing features
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] CI related changes infrastructure change
  • [ ] Other... Please describe:

Other useful information

MS data dir repo here: https://github.com/geosolutions-it/mapstore-datadir

MV88 avatar Aug 08 '22 10:08 MV88

@randomorder let's decide together the best approach. Thank you @MV88.

tdipisa avatar Aug 08 '22 10:08 tdipisa

As agreed also with @randomorder three branches have been created in mapstore-datadir repo, one for each MS instance we have to maintain: DEV, QA and STABLE.

@ibrahimcengizgeo has already versioned the current state while @MV88 will update each branch next days according to what scheduled for #7165.

Three additional J. Jobs or a GHA will be created to fetch updates from each branch of mapstore-datadir and so update the data dir of each instance (eg. one datadir update job for each MS instance). A separate issue (#1046) has been created for the implementation of these jobs/gha.

tdipisa avatar Aug 09 '22 09:08 tdipisa

@MV88 jenkins jobs are already in place and the update of data dirs is triggered automatically after few minutes when we commit/merge updates. I've asked @ibrahimcengizgeo to put a brief documentation about the three jobs in the repo readme.

tdipisa avatar Aug 09 '22 10:08 tdipisa

@tdipisa thanks, i like the fact there is no manual operation involved other than pushing changes to the datadir repo

MV88 avatar Aug 09 '22 10:08 MV88

@tdipisa, @MV88 it seems this task was assigned to me. if it's not related to me I will unassign it, I guess only https://github.com/geosolutions-it/DevOps/issues/1046 was on me.

ibrahimcengizgeo avatar Aug 10 '22 09:08 ibrahimcengizgeo

yes, you can unassign now

MV88 avatar Aug 10 '22 10:08 MV88

moving in Review. Related PRs for this issue are here:

  • https://github.com/geosolutions-it/mapstore-datadir/pull/2 that depends on:
    • ~Merge https://github.com/geosolutions-it/MapStore2/pull/8511~
      • --> Merge https://github.com/geosolutions-it/MapStore2/pull/8634 (replacement of previous PR)
    • ~Merge https://github.com/geosolutions-it/MapStore2/pull/8522~
      • --> Merge https://github.com/geosolutions-it/MapStore2/pull/8645 (replacement of previous PR)
  • https://github.com/geosolutions-it/mapstore-datadir/pull/3 that depends on
    • Testing of #2 above for DEV

tdipisa avatar Aug 30 '22 14:08 tdipisa

There are no functional changes in this PR. The refactor involves the geoserver integrations. So please test them on DEV and QA. I tested on myself the integration is working.

The only thing left is to merge this during release. https://github.com/geosolutions-it/mapstore-datadir/pull/4 Already noted in #8660

So I'm going to close and accept this issue

offtherailz avatar Oct 06 '22 08:10 offtherailz