MapStore2 icon indicating copy to clipboard operation
MapStore2 copied to clipboard

build: upgrade to jdk11 -> jdk17 for bundled jre

Open mahesh-wor opened this issue 2 months ago • 3 comments

Description

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

Issue

What is the current behavior? Earlier the jre bundle was being downloaded from dropbox url for jdk 11. Apache docker image was using tomcat:9-jdk11

What is the new behavior? New jdk17 bundle (win/linux) are fetched from https://maven.geo-solutions.it/jdk/17.0.13/ Apache docker image updated to usetomcat:9-jdk17

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • [ ] Yes, and I documented them in migration notes
  • [ ] No
  • [x] Locally Tested, Further to be verified with Github Actions build jobs.

Other useful information

mahesh-wor avatar Nov 17 '25 10:11 mahesh-wor

Waiting for PR to be merged, Will then rebase with master > update docs/developer-guide/requirements.md > Check build status with matrix implementation. Then we can merge it. @offtherailz

mahesh-wor avatar Dec 02 '25 09:12 mahesh-wor

Waiting for PR to be merged,

Thank you @mahesh-wor. Let's wait for v2025.02.00 to be out next week before merging that.

tdipisa avatar Dec 02 '25 10:12 tdipisa

Waiting for PR to be merged, Will then rebase with master > update docs/developer-guide/requirements.md > Check build status with matrix implementation. Then we can merge it. @offtherailz

@mahesh-wor v2025.02.00 is released. You can now proceed with that.

tdipisa avatar Dec 15 '25 15:12 tdipisa

Hi @tdipisa , seems like the Dockerfile and build stuff is changed from my last PR in master, i will do some test builds runs and update here.

mahesh-wor avatar Dec 17 '25 08:12 mahesh-wor

Hi @tdipisa , seems like the Dockerfile and build stuff is changed from my last PR in master, i will do some test builds runs and update here.

@mahesh-wor get in touch with brian if you have questions

randomorder avatar Dec 17 '25 08:12 randomorder

@offtherailz Hi tested local build with the changes i made, also updated java/jdk recommendation to v17.

FYI: We did an upgrade to postgres db version to Postgres 17 for Mapstore2 in this issue, but i see that the docker-compose has FROM postgis/postgis:12-3. and docs recommends postgres 13, minimum.

mahesh-wor avatar Dec 17 '25 15:12 mahesh-wor

FYI: We did an upgrade to postgres db version to Postgres 17 for Mapstore2 in this issue, but i see that the docker-compose has FROM postgis/postgis:12-3. and docs recommends postgres 13, minimum.

@mahesh-wor it was purpose of internal https://github.com/geosolutions-it/internal/issues/426 to provide the setup for PGSQL 16 or 17. Therefore, you have to provide all necessary pending changes with a new PR, I suppose. Can you raise it? We have to ensure all is aligned.

tdipisa avatar Dec 17 '25 16:12 tdipisa

Docker build failed @mahesh-wor . going to reopen the issue.

offtherailz avatar Dec 18 '25 08:12 offtherailz

ERROR: failed to build: failed to solve: tomcat:9-jdk17: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 500 Internal Server Error

Seems like something wrong with https://auth.docker.io/token, Error 500. I tested the key on the runner machine just now and there is no pull error, removing the image and rebuilding. Let's see if it works.

If it does not work, will investigate further.

mahesh-wor avatar Dec 18 '25 09:12 mahesh-wor

e5ade416e6d9: Pushed
baa3b6db37e5: Pushed
301589a7c094: Pushed
d3e3925959bc: Mounted from library/tomcat
be1d5d5aa9ea: Mounted from library/tomcat
db1688142012: Mounted from library/tomcat
d03939930dac: Mounted from library/tomcat
35c0b8fb11b1: Mounted from library/tomcat
e8bce0aabd68: Layer already exists
d7ef4463791e: Mounted from library/tomcat
79a638aab349: Pushed
6cfff8db9bd5: Pushed
841ca107cc80: Pushed
master-dev: digest: sha256:6893e2e564373b70df601ad85baf4f5033541731bedc72573e9f06b95eb1d8d1 size: 4290
Archiving artifacts
Sending e-mails to: [email protected]
Started calculate disk usage of build
Finished Calculation of disk usage of build in 0 seconds
Started calculate disk usage of workspace
Finished Calculation of disk usage of workspace in  3 second
Triggering a new build of MapStore » MapStore2-Dev-EndPointTests
Finished: SUCCESS

@offtherailz It's working now, I didn't change a thing. DockerHub had degraded performance issued yesterday. Could be that. https://www.dockerstatus.com/pages/history/533c6539221ae15e3f000031

mahesh-wor avatar Dec 18 '25 09:12 mahesh-wor