stetl icon indicating copy to clipboard operation
stetl copied to clipboard

Exit on error?

Open reinvantveer opened this issue 4 years ago • 3 comments

For the sake of discussion: a concern for me at the moment is the strategy for error handling - it appears to me that it is following a "keep calm and carry on" kind of thing :wink: . But what if you'd want to exit on error? The error itself (for example in postgis.tx_execute() gets assigned to self.e, but at what point can or should halt this error further execution?

The use case for this is to further support automated workflows - without having to resort to logfile analysis. You could scan logs for Errors of any kind in the logs, but it would be rather nice to fail the import when for some reason or other, the receiving end of the transformation isn't available or busy or something.

Any thoughts/pointers on this?

reinvantveer avatar Jun 18 '21 12:06 reinvantveer

Stopping on error is the right thing to do in my opinion, the current behaviour is very good.

sebastic avatar Nov 29 '21 13:11 sebastic

I'm not sure that the current behaviour exits on error though @sebastic can you confirm?

reinvantveer avatar Nov 29 '21 15:11 reinvantveer

It does not, I ran into it with NLExtract, see: https://github.com/nlextract/NLExtract/issues/331#issuecomment-975788906

sebastic avatar Nov 29 '21 15:11 sebastic