pywps icon indicating copy to clipboard operation
pywps copied to clipboard

Implement dynamic status

Open gschwind opened this issue 3 years ago • 4 comments

Overview

This patch suite implement the #354 with several refactor. I did this patch to simplify and split the previous PR #662 to make review easier. I expect to submit other relevant changes but I rework them to avoid dramatic change into the user API. For instance I did extended the service=WPS API by adding request=status instead of adding a new separate endpoint as I did in PR #662

Related Issue / Discussion

#662

Additional Information

This contribution is supported by MINES ParisTech.

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • [X] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [X] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

gschwind avatar Nov 09 '22 16:11 gschwind

Coverage Status

coverage: 83.516% (-0.5%) from 84.061% when pulling 667aea8ef2769c43fea03c55824626732cfa6f80 on gschwind:pr-implement-db-status-and-wpsrequest-rework into 10dd07a9ee55c3033e240fa882eebadfc3ac4ad8 on geopython:main.

coveralls avatar Nov 09 '22 16:11 coveralls

@fmigneault

You are welcome to test it and to provide feedbacks. I'm using it with my own WPS server :)

Best regards.

gschwind avatar Nov 10 '23 10:11 gschwind

Hello,

I did updated the patch suite to address comment above, to summarize changes:

  • I added an option to keep the legacy on-disk status file, disable by default
  • I changed the url of status to use [server] url + /status as compromise where users does not have to change configuration
  • I removed the operations decorator from the suite that provide no practical benefit
  • I removed relative import
  • I removed the move of WPS_STATUS and used an alternative import, i.e. I use late runtime import
  • Some tests are updated to simulate more accurately the wsgi environment.

I do not like to much the setup of URL but as said, it's compromise, maybe in futur we may implement a cleaner aproach.

Best regards

gschwind avatar Feb 07 '24 15:02 gschwind

Fix more relative imports

gschwind avatar Feb 09 '24 13:02 gschwind