pygeoapi icon indicating copy to clipboard operation
pygeoapi copied to clipboard

Oracle Provider: Different Count and Feature Queries in case a sql_manipulation class is used

Open Moritz-Langer opened this issue 1 year ago • 0 comments

Description Given that a sql_manipulation class is used within the oracle provider, the count query for "numberMatched" and the actual feature queries might be different queries. This can lead to wrong numberMatched and to wrong queries being executed.

Steps to Reproduce Steps to reproduce the behavior: sql_manipulator that adds/removes something to the where clause

Expected behavior Except the limit and offset params the where clauses should be the same for the count and the actual query. https://github.com/geopython/pygeoapi/blob/3bdeefe4e778ff5a0fd55637fc82a57a00bd0326/pygeoapi/provider/oracle.py#L696-L700 even if this changes the query: https://github.com/geopython/pygeoapi/blob/3bdeefe4e778ff5a0fd55637fc82a57a00bd0326/pygeoapi/provider/oracle.py#L799-L870

Screenshots/Tracebacks If applicable, add screenshots to help explain your problem.

Environment

  • OS:
  • Python version:
  • pygeoapi version:

Additional context Solution proposal is here: https://github.com/totycro/pygeoapi/blob/e2ba2c79cdcbd1b23601fba9f7f555a8d6644353/pygeoapi/provider/oracle.py#L696-L736

Moritz-Langer avatar Oct 16 '24 13:10 Moritz-Langer