pygeoapi icon indicating copy to clipboard operation
pygeoapi copied to clipboard

BaseProcessor without configuration parameter 'connection'

Open francescoingv opened this issue 2 years ago • 1 comments

Overview

BaseProcessor works also without configuration parameter connection.

Methods add_job() and update_job() are now called subject to the condition the configuration parameter connection is provided.

Additional minor changes: -) in BaseProcessor: improved the error description returned in case of errors during the processing. -) in API: improved returned message if an error is found during the parsing of the json input string -) in echoProcessor: amended returned message in case of wrong input parameter ``

Related Issue / Discussion

Solve #1440

Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • [X] I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
  • [X] I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

francescoingv avatar Dec 21 '23 10:12 francescoingv

The test failed because of the modification of Exception handling in pygeoapi/process/manager/base.py from (line 293):

            outputs = {
                'code': code,
                'description': 'Error updating job'
            }

to (line 296):

            outputs = {
                'code': code,
                'description': str(err)
            }

somehow implementing the note to the Exception: TODO assess correct exception type and description to help users.

I can change back the above line and resubmit the PR, but I would rather suggest to modify the test. Unfortunately I have no experience with testunits, and I cannot make any suggestion/proposal.

francescoingv avatar Jan 12 '24 11:01 francescoingv

This Pull Request has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

github-actions[bot] avatar May 26 '24 03:05 github-actions[bot]