pygeoapi icon indicating copy to clipboard operation
pygeoapi copied to clipboard

BaseManager.execute_process fails if connection is not defined

Open francescoingv opened this issue 2 years ago • 1 comments

Description Using the BaseManager as manager, while it is safe to not define the configuration parameter output_dir, it causes an error if it is not defined the configuration parameter connection.

I think it should be possible to safely use BaseManager also without the connection configuration parameter. All other methods that could benefit from this parameter (get_jobs, add_job, update_job, get_job, get_job_result, delete_job) currently return the proper Error, as they will possibly be implement by the derived classes as required.

Steps to Reproduce Modify the manager section of example-config.yml with the following lines:

    manager:
        name:  'pygeoapi.process.manager.base.BaseManager'

Call a EchoProcessor curl localhost:5000/processes/hello-world/execution -H 'Content-Type: application/json' -d '{"inputs": {"message": "my message,", "name": "My Name"}}' Expected behavior The call produce the following result:

{
    "id":"echo",
    "value":"Hello My Name! my message,"
}

Environment

  • OS: Ubuntu
  • Python version: 3.8.10
  • pygeoapi version: master

Additional context N/A

francescoingv avatar Dec 19 '23 10:12 francescoingv

This Issue has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

github-actions[bot] avatar Mar 24 '24 03:03 github-actions[bot]

As per RFC4, this Issue has been closed due to there being no activity for more than 90 days.

github-actions[bot] avatar Mar 31 '24 03:03 github-actions[bot]