react-phoenix icon indicating copy to clipboard operation
react-phoenix copied to clipboard

chore: Use PhoenixLiveView for rendering HTML

Open abshierjoel opened this issue 1 year ago • 1 comments

Phoenix.HTML has deprecated Phoenix.HTML.Tag since the 4.X release. Because of this, the content_tag function is no longer available. I think a good path forward may be to use Phoenix Components with the ~H sigil for formatting. Unfortunately this does require bringing in phoenix_live_view as a dependency, which may not be desirable.

abshierjoel avatar Jun 27 '24 20:06 abshierjoel

Hi @geolessel, just wanted to ping and see if you had seen this. Thanks!

abshierjoel avatar Sep 03 '24 18:09 abshierjoel

@abshierjoel ahhh! Sorry for being such a poor open source maintainer!

Thank you for the PR. If at all possible, I'd love to keep out LiveView. Without looking too closely yet, there is likely a way to get this done with regular EEx. Could you look into that?

geolessel avatar Dec 13 '24 21:12 geolessel

After looking at this, I noticed #68. I'm going to close this in favor of that approach. Thanks again for the PR and sorry for the delay!

geolessel avatar Dec 13 '24 21:12 geolessel