Prepare release of 5.0.0 for willdurand/geocoder

Open Nyholm opened this issue 2 years ago • 4 comments

Is there anything else we should add here?

https://github.com/geocoder-php/php-common/compare/4.6.0...master

Dec 21 '23 12:12 Nyholm

I'll investigate the checks that are failing on PHP 8.2 but the tests for BingMaps seems to fail only on PHP 8.3.

Geocoder\Provider\BingMaps\Tests\BingMapsTest::testGeocodeWithRealAddressReturnsMultipleResults unserialize(): Extra data starting at offset 3984 of 3985 bytes

Dec 28 '23 10:12 jbelien

@jbelien I guess it was wrong all the time and just popped up with PHP 8.3. https://php.watch/versions/8.3/unserialize-E-WARNING

I did create a PR (see above) to solve this. I am not sure if this is the best way. But i could not figure out where the LINE Carriage (i guess) at the File-End is created in the first place.

Mar 02 '24 10:03 Chris53897

✅ We're back on track: #1220

Mar 02 '24 11:03 jbelien