BazingaGeocoderBundle icon indicating copy to clipboard operation
BazingaGeocoderBundle copied to clipboard

Add types declarations

Open ker0x opened this issue 2 years ago • 4 comments

This PR add types declaration when possible. It also adds Rector as a dev dependency to facilitate code modernization.

ker0x avatar Sep 25 '23 09:09 ker0x

Thanks. Before merging this we should wait for https://github.com/geocoder-php/Geocoder/pull/1184

Just a question about rector: if the code is migrated once, then what's the point of introducing it as dependency?

norkunas avatar Oct 02 '23 06:10 norkunas

@norkunas It can help with further modernization (symfony migration, code refactoring, etc.). But if you prefer, I can remove it

ker0x avatar Oct 03 '23 06:10 ker0x

I understand, but how often it will be needed here? :) I think rector better suits for php projects than libraries. Imho it's easy enough to run once make a PR without including it as a dependency just to be downloaded everytime in CI.

norkunas avatar Oct 03 '23 07:10 norkunas

@norkunas good point. I updated my PR and removed Rector from it 😉

ker0x avatar Oct 03 '23 09:10 ker0x