web-mapviewer icon indicating copy to clipboard operation
web-mapviewer copied to clipboard

PB-368 : add "load more features" button in feature list

Open pakb opened this issue 1 year ago • 1 comments

Also load 50 features when selecting a rectangle on the map (instead of 10)

The piece of code that was triggering the identification of feature was a store plugin, I thought it would make more sense to move all this to the feature store. Especially as I needed to write a second "get more feature" way of loading things. So now the store plugins only triggers a dispatch instead of loading the feature itself.

Test link

pakb avatar May 03 '24 07:05 pakb

Passing run #2112 ↗︎

0 204 20 0 Flakiness 0

Details:

PB-368 : PR review
Project: web-mapviewer Commit: 7e29100c4f
Status: Passed Duration: 05:22 💡
Started: May 14, 2024 7:46 AM Ended: May 14, 2024 7:51 AM

Review all test suite changes for PR #820 ↗︎

cypress[bot] avatar May 03 '24 07:05 cypress[bot]

There is a black background around the tooltip of the zoom to extent, this looks quite ugly image what is the reason of this ?

ltshb avatar May 13 '24 04:05 ltshb

After selecting a bunch of features, clicking outside the selection box where there is nothing to select, the features stay selected when it should clear the selection.

ltshb avatar May 13 '24 04:05 ltshb

There is a black background around the tooltip of the zoom to extent, this looks quite ugly ! what is the reason of this ?

Seems like it was always there, but having 50 features increase the side-effects of the bug. The tippy selector used in the ZoomToExtentButton was re-applying the same tooltip over and over, with 10 it was still "subtle" shadows, but with 50... well you saw

pakb avatar May 13 '24 09:05 pakb