web-mapviewer icon indicating copy to clipboard operation
web-mapviewer copied to clipboard

PB-912 Fix language of background layer attribution

Open schtibe opened this issue 1 year ago • 1 comments

(the reason I am doing this was because I fixed something small when nobody else was around, this is like the extension of that) Some notes on the fix: the backgroundLayer was copied inside the store. When one changes the language, the attributions would therefore not be updated. One solution would be to listen to language changes and trigger the update (see first commit), but IMO this would diffuse the responsibility of the data further. So I changed the store a bit so the currentLayer comes through a getter, streamlining the data flow.

Test link

schtibe avatar Sep 02 '24 12:09 schtibe

web-mapviewer    Run #3440

Run Properties:  status check passed Passed #3440  •  git commit 0f04cff899: PB-912 Refactor map attribution for language updating
Project web-mapviewer
Branch Review feat-pb-912-swisstopo-source
Run status status check passed Passed #3440
Run duration 05m 21s
Commit git commit 0f04cff899: PB-912 Refactor map attribution for language updating
Committer Stefan Heinemann
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

cypress[bot] avatar Sep 20 '24 11:09 cypress[bot]