Character data should include their id

Open thomas-tcj opened this issue 4 years ago • 3 comments

Hey, I think it would be useful for the character data to include the identifier of the character.

This way, when parsing data from https://api.genshin.dev/characters/all, it would be possible to determine the URL for the icon of each character.

Happy to do it myself, if we can agree that this is a useful feature.

Oct 22 '21 07:10 thomas-tcj

I agree, it's very hard to identify characters. For example, vision is added to name for Traveler and others are identified by their name. In my opinion, Ids should be artificial and given in data. Anyway it would be very useful to include ids.

Dec 04 '21 21:12 JVO-sknife

I think it would be great, I had to make my own json file, and then I merged the two of them together. Here it is if anyone want to use it (Had to put .md cause github don't want .json...) CharactersId.json.md

Dec 27 '21 22:12 LolnationCH

Also agree identifiers would be helpful, created PR with the ids: https://github.com/genshindev/api/pull/220

Aug 05 '23 02:08 xannem