Add Swap Status for cross chain swap tx view
Fixes https://github.com/gemwalletcom/gem-ios/issues/381
Summary of Changes
Hello @0xh3rman, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This PR introduces comprehensive support for displaying cross-chain swap transaction statuses and details within the transaction view. It integrates a new SwapTransactionService to fetch real-time swap results, enhances the UI with dedicated status and transaction hash fields, and includes necessary infrastructure and localization updates.
Highlights
- Intent: This pull request aims to enhance the transaction details view by adding specific status and transaction hash information for cross-chain swap transactions. This allows users to quickly understand the state and details of their swaps, including source and destination transaction IDs.
-
Changes Summary: The PR introduces a new
SwapResulttype inPrimitivesto represent the status and details of a swap. A newSwapTransactionServiceis added toFeatureServices/SwapServiceto fetch these swap results from theGemSwapperlibrary, including logic to mapSwapperSwapResultto the newPrimitives.SwapResult. TheTransactionsfeature is updated to consume this new service. Specifically,TransactionSceneViewModelnow takes aSwapResultProvidingdependency, fetchesSwapResultfor cross-chain swaps using a polling mechanism with exponential backoff, and conditionally displays new UI elements. NewTransactionItemcases (swapStatus,sourceTransaction,destinationTransaction) are introduced, along with a newTransactionSwapHashViewModelto render the source and destination transaction hashes. The existingTransactionStatusViewModelis extended to display swap-specific statuses (e.g., 'Refunded') when aSwapResultis available. Dependency injection forSwapTransactionServiceis set up across the application's navigation stacks (TransactionsNavigationStack,WalletNavigationStack),AppResolver,ServicesFactory, andEnvironment. Localization strings for the new UI elements are also added. A new test case verifies the correct display of swap status and destination transaction details. - Reviewer Activity Summary: No specific reviewer activity was provided in the context.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
For Near Intents, we need to query by deposit address not tx hash, need to update SwapTransactionService to have local tx data (destination and memo etc)