ref-OpenHealthCardKit icon indicating copy to clipboard operation
ref-OpenHealthCardKit copied to clipboard

Wrong error message when CAN is incorrect

Open fabi-an-ro opened this issue 4 months ago • 6 comments

When scanning an eGK but with a wrong CAN provided, the NFCSession gets invalidated with the message Messages.noCardMessage in NFCHealthCardSession.swift:281. Because of this reason the user sees a wrong error message on the NFC system dialog.

Can you please fix that?

fabi-an-ro avatar Oct 02 '25 14:10 fabi-an-ro

Thanks for the hint. I opened a PR to fix it. https://github.com/gematik/ref-OpenHealthCardKit/pull/49

sigabrtz avatar Nov 11 '25 12:11 sigabrtz

Thanks 👍

fabi-an-ro avatar Nov 11 '25 12:11 fabi-an-ro

I merged it to main. We'll probably prepare a release next week.

sigabrtz avatar Nov 13 '25 12:11 sigabrtz

I made the release. If your project resolves OHCKit to >= 5.11.2 it should contain the fix

sigabrtz avatar Nov 27 '25 14:11 sigabrtz

Thank you very much 👍

fabi-an-ro avatar Nov 27 '25 14:11 fabi-an-ro

@sigabrtz Confirmed to be working, thank you for fixing it 👍

markusboesch avatar Dec 02 '25 15:12 markusboesch