New CAV models
Hi @mmpagani and @micheles,
@kslytherin and I are going to start working on a few new CAV models to contribute, specifically:
This issue's main purpose is to inform you about our plans and try to avoid duplicating effort, which happened for the Campbell and Bozorgnia model.
Also, the Liu and Macedo paper includes a conditional model, so I wanted to ask what the strategy for these models in OQ will be. If @g-weatherill's implementation in this PR has issues that prevent it from being merged, could we discuss how it needs to be modified to move things forward?
Thanks.
Also, I'll note that @kslytherin has an implementation of the Macedo et al. 2020 model that uses the ConditionalGMPE class by @g-weatherill. I'm pointing this out mostly to indicate that this is an important topic for us, and hopefully, OQ will also benefit from our contributions. If there are changes that are needed to the ConditionalGMPE class, we'll be happy to update the Macedo et al. 2020 implementation to reflect those changes.
Hi @mmpagani and @micheles,
@kslytherin and I are going to start working on a few new CAV models to contribute, specifically:
This issue's main purpose is to inform you about our plans and try to avoid duplicating effort, which happened for the Campbell and Bozorgnia model.
Also, the Liu and Macedo paper includes a conditional model, so I wanted to ask what the strategy for these models in OQ will be. If @g-weatherill's implementation in this PR has issues that prevent it from being merged, could we discuss how it needs to be modified to move things forward?
Thanks.
Hi @emthompson-usgs,
Thanks for sharing info on models for CAV you aim to add in OQ. Hopefully, we will avoid the problems we faced while implementing CB's model. Regarding the conditional model implementation, I will send an example of implementation based on the modifiable GMPE. When are you planning to start working on the Liu and Macedo conditional part?
Thanks
Hi @mmpagani,
@emthompson-usgs and I will start with the Bullock models first and then after we should get to the Liu and Macedo, but I would say it could take at least a few weeks until we get started on Liu and Macedo.
Hi Kyle, thanks. I will try to send an example by then.
Hi @mmpagani,
@emthompson-usgs and I will start with the Bullock models first and then after we should get to the Liu and Macedo, but I would say it could take at least a few weeks until we get started on Liu and Macedo.
-- Reply to this email directly or view it on GitHub: https://github.com/gem/oq-engine/issues/9897#issuecomment-2286606350 You are receiving this because you were mentioned.
Message ID: @.***>
Hi Kyle, thanks. I will try to send an example by then. … Hi @mmpagani, @emthompson-usgs and I will start with the Bullock models first and then after we should get to the Liu and Macedo, but I would say it could take at least a few weeks until we get started on Liu and Macedo. -- Reply to this email directly or view it on GitHub: #9897 (comment) You are receiving this because you were mentioned. Message ID: @.***>
Hi @mmpagani,
I am about to get to started on the Liu and Macedo, 2022 model.
Hi Kyle, I will share an example during this week. Sorry for the delay in replying. Busy period.
Hi Kyle, I will share an example during this week. Sorry for the delay in replying. Busy period.
@mmpagani No problem. We are starting on the non-conditional models first and I am working on some other things too so that can buy you some time. I don't expect to start on the conditional model for at least another 2 weeks.
@kslytherin and I are going to start working on a few new CAV models to contribute, specifically:
* [Bullock et al. 2019](https://doi.org/10.5459/bnzsee.52.4.193-207) * [Bullock et al. 2021](https://doi.org/10.1177/8755293020957342) * [Liu and Macedo, 2022](https://doi.org/10.1177/87552930211043897)This issue's main purpose is to inform you about our plans and try to avoid duplicating effort, which happened for the Campbell and Bozorgnia model.
Also, the Liu and Macedo paper includes a conditional model, so I wanted to ask what the strategy for these models in OQ will be. If @g-weatherill's implementation in this PR has issues that prevent it from being merged, could we discuss how it needs to be modified to move things forward?
Thanks.
Liu and Macedo, 2022 and Macedo et al. 2020 are in the process of being added. They are in the current pull requests if someone is interested. We have made progress doing Bullock et al. 2019 and Bullock et al. 2021 but have trouble replicating their work so things are at a standstill. On another note, we plan to start adding in another CAV from Farhadi and Pezeshk 2020 in the next few weeks.