oq-engine icon indicating copy to clipboard operation
oq-engine copied to clipboard

Possible workaround for truncation

Open mmpagani opened this issue 4 years ago • 4 comments

mmpagani avatar Aug 30 '21 10:08 mmpagani

The tests break because the scaling is a vector and not a scalar. A possible solution is to use a mean scaling factor:

                scaling = ((stddev_inter + stddev_inter) /
                           (stddev_inter**2 + stddev_intra**2)**0.5).mean()

micheles avatar Aug 31 '21 04:08 micheles

Following the analysis in https://github.com/gem/oq-engine/pull/7151 this approach is not enough to solve the problem, since the issue is present also in the case where only STDDEV_TOTAL is defined, i.e. it is not caused by the effect that we are trying to address here.

micheles avatar Sep 03 '21 04:09 micheles

Given the discussion of this morning, I would close this PR.

micheles avatar Sep 03 '21 13:09 micheles

Reopened since Robin is working on this.

micheles avatar Sep 24 '21 08:09 micheles