Sam Livingston-Gray

https://twitter.com/tzadik/status/664533143328858113

Use of PRNG can cause pathological performance in 'bisect' tools

8

## TL;DR Using Faker to generate data for tests _**can**_ (in combination with complex app behavior) create test flakiness that is extremely difficult to track down. To y'all's credit, the...

as per #109, also relates to options

possibly with options (I assume Llewellyn knows what this means)

Possibly this already exists (lol, you want me to read the README?), but: https://github.com/approvals/ApprovalTests.Ruby/runs/8235260417?check_suite_focus=true for JRuby indicates that approvals failed, but not what or why

This repo appears to be abandonware?

5

Helping a colleague try to debug `UnknownError` in dealing with this API, and I notice a PR (#36) related to it. That PR has five "+1" comments and a few...

^ r make tests pass on all current Ruby versions

2

## Description Ruby 3.4 changed the behavior of `Hash#inspect` ([bug 20433](https://bugs.ruby-lang.org/issues/20433)). Because the `Approvals::Writers::ArrayWriter` and `Approvals::Writers::HashWriter` use `#inspect` to serialize the contents of arrays and hashes, this made it impossible...

Refactor Launcher

1

## Description Hi, Llewellyn! This is a followup from yesterday's pairing session. You didn't push your branch, but it was useful for me to engage with the code anyway. 😜...