Graeme Porteous
Graeme Porteous
@garethrees this should be working now. There is loads of fixups do you want to see those or should I go ahead and rebase before you re-review?
Specs are green locally not sure why GitHub actions aren't running.
> On running I get: > Missed a file, pushed a fixup
Superseded by #7391
There is a model validation for the type field. Would need to update https://github.com/mysociety/alaveteli/blob/fa6f8d63913f09c5b5ccc31654cf66718ac65abf/app/models/citation.rb#L32-L33 too.
> Not sure there's an easy way around this at present? I had a good at fixing this with what is available to us right now. Double `admin_column` block loop...
@garethrees I have fixed up and split the commit into 4 separate ones. I think its good to go now.
7. Record version history of notes
I would add a `sluggable` concern to the above list. `PublicBody`, `InfoRequest` and `Users` all currently have this baked into their models which could be extracted out
Re taggable, since https://github.com/mysociety/alaveteli/commit/1b01522483d065ee6675dc48117bee6e2d77cbc3 the association is now polymorphic.