sabconnectplusplus icon indicating copy to clipboard operation
sabconnectplusplus copied to clipboard

Add support for new newznab bookstrap theme

Open lilHermit opened this issue 9 years ago • 9 comments

Please add support for the new newznab theme/template called bookstrap. Please see screengrab screenshot from 2016-05-03 14-47-28

lilHermit avatar May 03 '16 13:05 lilHermit

Do you have access to such a service and willing to provide some technical details to assist?

Without access to a page rendered in that theme, there is little to see on why the current selectors do not work, or what needs adding / changed to get it running.

ppslim avatar May 03 '16 18:05 ppslim

Yeah I can give you access to an install, email me at [email protected] and I'll send over the details. (Email valid for 1 week)

Edit: Extended email validity until 16/05/16

lilHermit avatar May 03 '16 20:05 lilHermit

bump ;-)

lilHermit avatar May 17 '16 12:05 lilHermit

Sorry, I had not seen a way for you to send it.

I note the email address may now be invalid, but I have emailed it regardless. It may be best to try and catch me before the weekend as time is not my friend recently.

ppslim avatar May 18 '16 13:05 ppslim

Ok try email me here [email protected] and we'll get things rolling. I can certainly set you up asap

lilHermit avatar May 18 '16 13:05 lilHermit

Having had a quick scan, there are a number of factors.

Detecting and inserting looks does not appear to be too difficult, however...

The template purposefully comments out the RSSTOKEN input field and means the API key cannot be extracted from the DOM easily.

The API for getting the NZB file itself looks to be very different, which may mean a different submission mechanism.

Overall, this may be difficult and easy in one. I should get around to looking in more detail this weekend.

ppslim avatar May 19 '16 08:05 ppslim

Ok let me know if there anything you need. In the meantime I'll do a source update to see if anything has changed with the theme

lilHermit avatar May 19 '16 08:05 lilHermit

I have done a first pass at the selectors required for this.

The page structure has changed a lot, but that isn't unexpected given this is a Bootstrap page.

The List & Cover views are covered in this, however, they will now download to sab yet, just render links.

You would need to install a local extension to test this after downloading from my iss141 branch ppslim/sabconnectplusplus@218d9b8

ppslim avatar May 19 '16 21:05 ppslim

Looks good I see the rendering of the buttons!

lilHermit avatar May 20 '16 13:05 lilHermit