Boot-up B register values
Unifies #72 and #74 as requested.
I'm not sure if that would be a good idea, since they are being removed for a reason.
Everything in hardware_compat.inc was removed for a reason. It's there for backwards compatibility.
Actually, it might be a good idea to add a comment in hardware_compat.inc with an explanation for every significant change, such as this one.
Actually, it might be a good idea to add a comment in
hardware_compat.incwith an explanation for every significant change, such as this one.
Maybe so; some already have such comments, e.g. the ones suggesting RGBASM-feature alternatives.
Maybe so; some already have such comments, e.g. the ones suggesting RGBASM-feature alternatives.
So do we agree on this warranting a separate line with a comment?
LGTM, thank you! I'm not actually merging it yet because:
- We have multiple ongoing PRs, it might be convenient to iron them all out, then merge all at once and call it a new release
- This removes some constants from hardware.inc and so is a breaking change, needing version number 6.0
- When we get around to 6.0 I also want to fix #64
Since we're already breaking it, please consider updating hardware.inc to use S_* for consistency.
@Rangi42 do we have a PR for https://github.com/gbdev/hardware.inc/issues/64 ?