hardware.inc icon indicating copy to clipboard operation
hardware.inc copied to clipboard

Add constants from pokecrystal

Open rawr51919 opened this issue 3 years ago • 5 comments

This PR is a proof-of-concept showing what a hardware.inc using constants from pokecrystal would look like. Some of these names can be used for new names for constants down the line, so this one might be a little while before any action comes of this. Fixes #26

rawr51919 avatar Jul 05 '22 22:07 rawr51919

I don't know if there was prior discussion about this, but I think this would really clutter the file simply to become compatible with pokecrystal. Why not update pokecrystal to conform to hardware.inc instead?

evie-calico avatar Jul 05 '22 23:07 evie-calico

I don't know if there was prior discussion about this, but I think this would really clutter the file simply to become compatible with pokecrystal. Why not update pokecrystal to conform to hardware.inc instead?

There wasn't much in the way of discussion about this, yet pokecrystal's PR #943 does exactly that

rawr51919 avatar Jul 05 '22 23:07 rawr51919

I think rather than updating this file to support every different project's naming scheme, we should get the projects to settle on using hardware.inc

evie-calico avatar Jul 05 '22 23:07 evie-calico

Backported a constant addition from this PR to #33, RPB_LED_ON. I had forgot to add it during #31

rawr51919 avatar Jul 05 '22 23:07 rawr51919

I think rather than updating this file to support every different project's naming scheme, we should get the projects to settle on using hardware.inc

There has also been an issue opened on the subject on pokecrystal issue #914

rawr51919 avatar Jul 06 '22 04:07 rawr51919