BackstopJS icon indicating copy to clipboard operation
BackstopJS copied to clipboard

potential fix for puppet warning

Open Neychok opened this issue 2 years ago • 2 comments

Would something like this fix https://github.com/garris/BackstopJS/issues/1485 ?

I've never contributed to BackstopJS before so I am sorry if I missed any steps when creating this PR.

Happy to work on this more, if any other changes are required.

Neychok avatar Jun 22 '23 12:06 Neychok

You would need to pass the string "new" to fix that warning - but I can't recommend using new yet, see the issue comment.

tkrah avatar Jul 05 '23 12:07 tkrah

Thanks for the work on this @Neychok — I submitted a new PR which will work with backwards compatibility in mind.

dgrebb avatar Nov 22 '23 18:11 dgrebb