machine-controller-manager icon indicating copy to clipboard operation
machine-controller-manager copied to clipboard
verified publisher icon gardener

Do not set finalizers on MachineSets and MachineDeployments

Open mvladev opened this issue 5 years ago • 2 comments

What happened:

Don't set finalizers on MachineSets and MachineDeployments

What you expected to happen:

Those resources managed by MCM have machine.sapcloud.io/machine-controller-manager finalizer. Such higher level resources should not have that finalizer. Only Machine should have it.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Environment:

mvladev avatar Oct 02 '20 07:10 mvladev

I remember you had opened this PR - https://github.com/gardener/machine-controller-manager/pull/285 long back and it still exists today. And i also remember vaguely having a discussion around this PR. However, i am unable to remember why we didn't discuss on the PR. Let's relook at this.

prashanth26 avatar Oct 02 '20 07:10 prashanth26

We don't know what discussion happened in past , but we think finalizer can be removed because of proper owner references which are already set on the machine and machineSet resources. But it needs more testing to confirm.

himanshu-kun avatar Feb 14 '23 11:02 himanshu-kun