c0d3-app icon indicating copy to clipboard operation
c0d3-app copied to clipboard

Upgrade storybook and its addons to v7

Open flacial opened this issue 2 years ago • 3 comments

Problem

TypeScript won't get upgraded to v5 because of this bug with storybook. And all of storybook addons won't be upgraded to v7. They provided two solutions, a workaround and upgrading to v7.

Solution

  • Follow this guide for upgrading storybook: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-65x-to-700
  • Follow this guide for upgrading storybook/react: https://storybook.js.org/migration-guides/7.0

After this, you'll have to fix the breaking changes.

  • Update our Vercel build step to use Node.js v16
  • Upgrading webpack to v5

On second thought, I think the two links are the same.

flacial avatar Mar 26 '23 22:03 flacial

Related to https://github.com/garageScript/c0d3-app/pull/2859

flacial avatar Mar 26 '23 22:03 flacial

There are a few issues preventing the migration:

  • [x] The flag -s is working to define the static assets directory
  • [x] SCSS files are getting compiled as SASS
  • [ ] Memory leak when running the storybook server with all the stories

flacial avatar Apr 08 '23 13:04 flacial

Currently, we can't upgrade to v7 because of a memory leak when building and starting up storybook.

flacial avatar May 12 '23 20:05 flacial